Re: [PATCH] slob: fix linking for user mode linux

2008-02-11 Thread Pekka Enberg
Jeff Dike wrote: UML defined its own external __kmalloc and things. Isnt there some other way to fix it? I guess including slab.h is not possible here? > It would be an annoyance to reintroduce um_kmalloc, but that might be the best thing to do here. I'm ok with that as long as we get this an

Re: [PATCH] slob: fix linking for user mode linux

2008-02-11 Thread Jeff Dike
On Mon, Feb 11, 2008 at 02:44:21PM -0800, Christoph Lameter wrote: > UML defined its own external __kmalloc and things. Isnt there some other > way to fix it? I guess including slab.h is not possible here? This is definitely dubious code on my part and I wouldn't support Pekka's patch unless you'

Re: [PATCH] slob: fix linking for user mode linux

2008-02-11 Thread Christoph Lameter
On Mon, 11 Feb 2008, Matt Mackall wrote: > Can someone explain why the magic is needed (and preferably capture it > in a comment somewhere sensible)? I took a peek at this and have no idea > what's going on. UML defined its own external __kmalloc and things. Isnt there some other way to fix it?

Re: [PATCH] slob: fix linking for user mode linux

2008-02-11 Thread Matt Mackall
On Tue, 2008-02-12 at 00:32 +0200, Pekka J Enberg wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > UML has some header magic that expects a non-inline __kmalloc() function to be > available. Fixes the following link time errors: > > arch/um/drivers/built-in.o: In function `kmalloc': > /home/p

[PATCH] slob: fix linking for user mode linux

2008-02-11 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> UML has some header magic that expects a non-inline __kmalloc() function to be available. Fixes the following link time errors: arch/um/drivers/built-in.o: In function `kmalloc': /home/penberg/linux-2.6/arch/um/include/um_malloc.h:14: undefined reference to