Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread Ian Kumlien
On ons, 2007-10-03 at 14:04 -0400, Bill Davidsen wrote: > Ian Kumlien wrote: > > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > >> Remove unneeded check that caused problems with jumbo frame sizes. > >> The check was recently added and is wrong. > >> When using jumbo frames the sky2

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread Bill Davidsen
Ian Kumlien wrote: On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: Remove unneeded check that caused problems with jumbo frame sizes. The check was recently added and is wrong. When using jumbo frames the sky2 driver does fragmentation, so rx_data_size is less than mtu. Confirmed w

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread Jeff Garzik
Stephen Hemminger wrote: Remove unneeded check that caused problems with jumbo frame sizes. The check was recently added and is wrong. When using jumbo frames the sky2 driver does fragmentation, so rx_data_size is less than mtu. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied -

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread iank
On Tue, Oct 02, 2007 at 09:59:14PM -0700, Stephen Hemminger wrote: > On Wed, 03 Oct 2007 03:34:34 +0200 > Ian Kumlien <[EMAIL PROTECTED]> wrote: > > > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > > > Remove unneeded check that caused problems with jumbo frame sizes. > > > The chec

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread Ian Kumlien
On tis, 2007-10-02 at 21:59 -0700, Stephen Hemminger wrote: > On Wed, 03 Oct 2007 03:34:34 +0200 > Ian Kumlien <[EMAIL PROTECTED]> wrote: > > > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > > > Remove unneeded check that caused problems with jumbo frame sizes. > > > The check was r

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Stephen Hemminger
On Wed, 03 Oct 2007 03:34:34 +0200 Ian Kumlien <[EMAIL PROTECTED]> wrote: > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > > Remove unneeded check that caused problems with jumbo frame sizes. > > The check was recently added and is wrong. > > When using jumbo frames the sky2 driver

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Jeff Garzik
Stephen Hemminger wrote: On Tue, 02 Oct 2007 21:07:22 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: Remove unneeded check that caused problems with jumbo frame sizes. The check was recently added and is wrong. When using jumbo frames the sky2 driver does fragmentation,

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Stephen Hemminger
On Tue, 02 Oct 2007 21:07:22 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Remove unneeded check that caused problems with jumbo frame sizes. > > The check was recently added and is wrong. > > When using jumbo frames the sky2 driver does fragmentation, so > > rx_data_

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Ian Kumlien
On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > Remove unneeded check that caused problems with jumbo frame sizes. > The check was recently added and is wrong. > When using jumbo frames the sky2 driver does fragmentation, so > rx_data_size is less than mtu. Confirmed working. Now ru

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Jeff Garzik
Stephen Hemminger wrote: Remove unneeded check that caused problems with jumbo frame sizes. The check was recently added and is wrong. When using jumbo frames the sky2 driver does fragmentation, so rx_data_size is less than mtu. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers

[PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Stephen Hemminger
Remove unneeded check that caused problems with jumbo frame sizes. The check was recently added and is wrong. When using jumbo frames the sky2 driver does fragmentation, so rx_data_size is less than mtu. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-10-