Re: [PATCH] skbuff: fix compilation warnings in skb_dump()

2019-07-16 Thread Joe Perches
On Tue, 2019-07-16 at 17:04 +0200, Willem de Bruijn wrote: > On Tue, Jul 16, 2019 at 4:56 PM Qian Cai wrote: > > Fix them by using the proper types, and also fix some checkpatch > > warnings by using pr_info(). > > > > WARNING: printk() should include KERN_ facility level > > + prin

Re: [PATCH] skbuff: fix compilation warnings in skb_dump()

2019-07-16 Thread Willem de Bruijn
On Tue, Jul 16, 2019 at 4:56 PM Qian Cai wrote: > > The commit 6413139dfc64 ("skbuff: increase verbosity when dumping skb > data") introduced a few compilation warnings. > > net/core/skbuff.c:766:32: warning: format specifies type 'unsigned > short' but the argument has type 'unsigned int' [-Wform

[PATCH] skbuff: fix compilation warnings in skb_dump()

2019-07-16 Thread Qian Cai
The commit 6413139dfc64 ("skbuff: increase verbosity when dumping skb data") introduced a few compilation warnings. net/core/skbuff.c:766:32: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat] level, sk->sk_family, sk->sk_type