Re: [PATCH] signal/ptrace: Don't leak unitialized kernel memory with PTRACE_PEEK_SIGINFO

2019-06-10 Thread Eric Biggers
On Tue, Jun 04, 2019 at 02:42:23PM -0500, Eric W. Biederman wrote: > Andrei Vagin writes: > > > On Tue, May 28, 2019 at 6:22 PM Eric W. Biederman > > wrote: > >> > >> > >> Recently syzbot in conjunction with KMSAN reported that > >> ptrace_peek_siginfo can copy an uninitialized siginfo to users

Re: [PATCH] signal/ptrace: Don't leak unitialized kernel memory with PTRACE_PEEK_SIGINFO

2019-06-04 Thread Eric W. Biederman
Andrei Vagin writes: > On Tue, May 28, 2019 at 6:22 PM Eric W. Biederman > wrote: >> >> >> Recently syzbot in conjunction with KMSAN reported that >> ptrace_peek_siginfo can copy an uninitialized siginfo to userspace. >> Inspecting ptrace_peek_siginfo confirms this. >> >> The problem is that of

Re: [PATCH] signal/ptrace: Don't leak unitialized kernel memory with PTRACE_PEEK_SIGINFO

2019-06-04 Thread Andrei Vagin
On Tue, May 28, 2019 at 6:22 PM Eric W. Biederman wrote: > > > Recently syzbot in conjunction with KMSAN reported that > ptrace_peek_siginfo can copy an uninitialized siginfo to userspace. > Inspecting ptrace_peek_siginfo confirms this. > > The problem is that off when initialized from args.off ca

[PATCH] signal/ptrace: Don't leak unitialized kernel memory with PTRACE_PEEK_SIGINFO

2019-05-28 Thread Eric W. Biederman
Recently syzbot in conjunction with KMSAN reported that ptrace_peek_siginfo can copy an uninitialized siginfo to userspace. Inspecting ptrace_peek_siginfo confirms this. The problem is that off when initialized from args.off can be initialized to a negaive value. At which point the "if (off >=