Re: [PATCH] sh: dma: Add missing IS_ERR test

On Sat, 8 Jun 2019, Geert Uytterhoeven wrote: Hi Geert, thank you for your reply and your additional findings. > Hi Rolf, > > Thanks for your patch! > > On Fri, Jun 7, 2019 at 2:04 PM Rolf Evers-Fischer > wrote: > > get_dma_channel may return ERR_PTR, so a check is added. > > It may also r

Re: [PATCH] sh: dma: Add missing IS_ERR test

Hello Sergei, thanks for your feedback. On Sat, 8 Jun 2019, Sergei Shtylyov wrote: > Hello! > > On 07.06.2019 14:54, Rolf Evers-Fischer wrote: > > > get_dma_channel may return ERR_PTR, so a check is added. > > > > Signed-off-by: Rolf Evers-Fischer > > --- > > arch/sh/drivers/dma/dma-api.c

Re: [PATCH] sh: dma: Add missing IS_ERR test

Hi Rolf, Thanks for your patch! On Fri, Jun 7, 2019 at 2:04 PM Rolf Evers-Fischer wrote: > get_dma_channel may return ERR_PTR, so a check is added. It may also return NULL... > --- a/arch/sh/drivers/dma/dma-api.c > +++ b/arch/sh/drivers/dma/dma-api.c > @@ -94,7 +94,7 @@ int get_dma_residue(uns

Re: [PATCH] sh: dma: Add missing IS_ERR test

Hello! On 07.06.2019 14:54, Rolf Evers-Fischer wrote: get_dma_channel may return ERR_PTR, so a check is added. Signed-off-by: Rolf Evers-Fischer --- arch/sh/drivers/dma/dma-api.c | 20 +++- arch/sh/drivers/dma/dma-sysfs.c | 2 +- 2 files changed, 20 insertions(+), 2 del

[PATCH] sh: dma: Add missing IS_ERR test

get_dma_channel may return ERR_PTR, so a check is added. Signed-off-by: Rolf Evers-Fischer --- arch/sh/drivers/dma/dma-api.c | 20 +++- arch/sh/drivers/dma/dma-sysfs.c | 2 +- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/