Re: [PATCH] sgi-gru: simplify procfs code some more

2019-10-07 Thread Dimitri Sivanich
While a reduction in object size is welcome, in this case it does come at the expense of some clarity, as field sizes are no longer as clear. Nevertheless, will add my ack. Acked-by: Dimitri Sivanich On Mon, Oct 07, 2019 at 11:30:46AM -0700, Joe Perches wrote: > Use seq_puts and simple string ou

[PATCH] sgi-gru: simplify procfs code some more

2019-10-07 Thread Joe Perches
Use seq_puts and simple string output and not seq_printf with formats and individual strings to reduce overall object size. $ size drivers/misc/sgi-gru/gruprocfs.o* (x86-64 defconfig with gru) textdata bss dec hex filename 7006 8 070141b66 drivers/misc/sgi