Re: [PATCH] sg: atomize check and set sdp->exclude in sg_open

2013-06-06 Thread vaughan
于 2013年06月06日 15:19, vaughan 写道: 于 2013年06月05日 23:41, Jörn Engel 写道: On Thu, 6 June 2013 00:16:45 +0800, vaughan wrote: 于 2013年06月05日 21:27, Jörn Engel 写道: On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: Check and set sdp->exclude should be atomic when set in sg_open(). The patch is lin

Re: [PATCH] sg: atomize check and set sdp->exclude in sg_open

2013-06-06 Thread vaughan
于 2013年06月05日 23:41, Jörn Engel 写道: On Thu, 6 June 2013 00:16:45 +0800, vaughan wrote: 于 2013年06月05日 21:27, Jörn Engel 写道: On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: Check and set sdp->exclude should be atomic when set in sg_open(). The patch is line-wrapped. More importantly, it d

Re: [PATCH] sg: atomize check and set sdp->exclude in sg_open

2013-06-05 Thread Jörn Engel
On Thu, 6 June 2013 00:16:45 +0800, vaughan wrote: > 于 2013年06月05日 21:27, Jörn Engel 写道: > >On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: > >> > >>Check and set sdp->exclude should be atomic when set in sg_open(). > > > >The patch is line-wrapped. More importantly, it doesn't seem to do > It'

Re: [PATCH] sg: atomize check and set sdp->exclude in sg_open

2013-06-05 Thread vaughan
于 2013年06月05日 21:27, Jörn Engel 写道: On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: Check and set sdp->exclude should be atomic when set in sg_open(). The patch is line-wrapped. More importantly, it doesn't seem to do It's shorter than the original line, so I just leave it like this...

Re: [PATCH] sg: atomize check and set sdp->exclude in sg_open

2013-06-05 Thread Jörn Engel
On Wed, 5 June 2013 17:18:33 +0800, vaughan wrote: > > Check and set sdp->exclude should be atomic when set in sg_open(). The patch is line-wrapped. More importantly, it doesn't seem to do what your description indicates it should do. And lastly, does this fix a bug, possibly even one you have

[PATCH] sg: atomize check and set sdp->exclude in sg_open

2013-06-05 Thread vaughan
Check and set sdp->exclude should be atomic when set in sg_open(). Signed-off-by: Vaughan Cao --- drivers/scsi/sg.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 25b5455..0ede08f 100644 --- a/drivers/scsi/sg.c +