Re: [PATCH] sfc_ef100: Fix build failure on powerpc

2020-08-13 Thread Segher Boessenkool
On Thu, Aug 13, 2020 at 02:39:10PM +, Christophe Leroy wrote: > ppc6xx_defconfig fails building sfc.ko module, complaining > about the lack of _umoddi3 symbol. > > This is due to the following test > > if (EFX_MIN_DMAQ_SIZE % reader->value) { > > Because reader->value is u64. >

Re: [PATCH] sfc_ef100: Fix build failure on powerpc

2020-08-13 Thread Edward Cree
On 13/08/2020 15:39, Christophe Leroy wrote: > ppc6xx_defconfig fails building sfc.ko module, complaining > about the lack of _umoddi3 symbol. > > This is due to the following test > > if (EFX_MIN_DMAQ_SIZE % reader->value) { > > Because reader->value is u64. Already fixed in net.git

[PATCH] sfc_ef100: Fix build failure on powerpc

2020-08-13 Thread Christophe Leroy
ppc6xx_defconfig fails building sfc.ko module, complaining about the lack of _umoddi3 symbol. This is due to the following test if (EFX_MIN_DMAQ_SIZE % reader->value) { Because reader->value is u64. As EFX_MIN_DMAQ_SIZE value is 512, reader->value is obviously small enough for a