Re:Re: [PATCH] setlocalversion: fix error detectition of kernel git repository

I'm sorry. My patch is error. But I just want to get the git version when we use git as SCM. No matter what .git directory where. Thanks. At 2017-01-22 04:54:54, "Nico Schottelius" wrote: > >Hello Xufeng, > >why do you think redirecting *all* output to /dev/null is the right >thing todo? > >

Re: [PATCH] setlocalversion: fix error detectition of kernel git repository

Hello Xufeng, why do you think redirecting *all* output to /dev/null is the right thing todo? And which problem does it exactly fix? Do you see that there is a difference between a "return value" (i.e. exit code) and the output (in this case stdout) of a program? Best, Nico xufeng writes:

[PATCH] setlocalversion: fix error detectition of kernel git repository

This patch fixed the error using 'git rev-parse --show-cdup' to check that git is used as SCM to track the current directory. The return value of this command is not null string when the .git directory is not in kernel topdir. Signed-off-by: Xufeng Wang ---  scripts/setlocalversion | 2 +-  1 file