Re: [PATCH] serial_core: fix uart PORT_UNKNOWN handling

2014-04-16 Thread gre...@linuxfoundation.org
On Wed, Apr 09, 2014 at 05:06:24PM +0200, Thomas Pfaff wrote: > > On Wed, 9 Apr 2014, One Thousand Gnomes wrote: > > > On Wed, 9 Apr 2014 13:22:14 +0200 > > Thomas Pfaff wrote: > > > > > 1. uart_change_pm ist called during uart_open and calls the uart pm > > > function > > >without checkin

Re: [PATCH] serial_core: fix uart PORT_UNKNOWN handling

2014-04-09 Thread Thomas Pfaff
On Wed, 9 Apr 2014, One Thousand Gnomes wrote: > On Wed, 9 Apr 2014 13:22:14 +0200 > Thomas Pfaff wrote: > > > 1. uart_change_pm ist called during uart_open and calls the uart pm function > >without checking for PORT_UNKNOWN. > > Removing this breaks other parts of the code assume that the

Re: [PATCH] serial_core: fix uart PORT_UNKNOWN handling

2014-04-09 Thread One Thousand Gnomes
On Wed, 9 Apr 2014 13:22:14 +0200 Thomas Pfaff wrote: > From: "Thomas Pfaff" > > While porting a RS485 driver from 2.6.29 to 3.14, i noticed that the serial > tty > driver could break it by using uart ports that it does not own : Yes thats one spectacularly ugly driver that doesn't want inte

[PATCH] serial_core: fix uart PORT_UNKNOWN handling

2014-04-09 Thread Thomas Pfaff
From: "Thomas Pfaff" While porting a RS485 driver from 2.6.29 to 3.14, i noticed that the serial tty driver could break it by using uart ports that it does not own : 1. uart_change_pm ist called during uart_open and calls the uart pm function without checking for PORT_UNKNOWN. 2. uart_shutdo