Re: [PATCH] serial: add a new helper function

2012-08-20 Thread Huang Shijie
On Sun, Aug 19, 2012 at 11:46 PM, Alan Cox wrote: > On Sat, 18 Aug 2012 23:44:29 -0700 > Greg KH wrote: > >> On Sun, Aug 19, 2012 at 02:27:12PM -0400, Huang Shijie wrote: >> > --- a/include/linux/tty.h >> > +++ b/include/linux/tty.h >> > @@ -43,6 +43,7 @@ >> > #include >> > #include >> > #in

Re: [PATCH] serial: add a new helper function

2012-08-19 Thread Alan Cox
On Sat, 18 Aug 2012 23:44:29 -0700 Greg KH wrote: > On Sun, Aug 19, 2012 at 02:27:12PM -0400, Huang Shijie wrote: > > --- a/include/linux/tty.h > > +++ b/include/linux/tty.h > > @@ -43,6 +43,7 @@ > > #include > > #include > > #include > > +#include > > > > > > > > @@ -513,6 +514,12 @

Re: [PATCH] serial: add a new helper function

2012-08-19 Thread Huang Shijie
On Sun, Aug 19, 2012 at 2:44 AM, Greg KH wrote: > On Sun, Aug 19, 2012 at 02:27:12PM -0400, Huang Shijie wrote: >> --- a/include/linux/tty.h >> +++ b/include/linux/tty.h >> @@ -43,6 +43,7 @@ >> #include >> #include >> #include >> +#include >> >> >> >> @@ -513,6 +514,12 @@ static inline stru

Re: [PATCH] serial: add a new helper function

2012-08-18 Thread Greg KH
On Sun, Aug 19, 2012 at 02:27:12PM -0400, Huang Shijie wrote: > --- a/include/linux/tty.h > +++ b/include/linux/tty.h > @@ -43,6 +43,7 @@ > #include > #include > #include > +#include > > > > @@ -513,6 +514,12 @@ static inline struct tty_port *tty_port_get(struct > tty_port *port) >

[PATCH] serial: add a new helper function

2012-08-18 Thread Huang Shijie
In most of the time, the driver needs to check if the cts flow control is enabled. But now, the driver checks the ASYNC_CTS_FLOW flag manually, which is not a grace way. So add a new wraper function to make the code tidy and clean. Signed-off-by: Huang Shijie --- drivers/char/pcmcia/synclink_cs.