Re: [PATCH] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

2016-04-01 Thread Kefeng Wang
On 2016/4/1 17:58, Andy Shevchenko wrote: > On Fri, 2016-04-01 at 17:06 +0800, Kefeng Wang wrote: >> Commit cdcea058e510("serial: 8250_dw: Avoid serial_outx code >> duplicate >> with new dw8250_check_lcr()") introduce a wrong logic when write val >> to >> LCR reg. When CONFIG_64BIT enabled, __raw

Re: [PATCH] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

2016-04-01 Thread Andy Shevchenko
On Fri, 2016-04-01 at 17:06 +0800, Kefeng Wang wrote: > Commit cdcea058e510("serial: 8250_dw: Avoid serial_outx code > duplicate > with new dw8250_check_lcr()") introduce a wrong logic when write val > to > LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used > unconditionally. > > But for !PO

[PATCH] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

2016-04-01 Thread Kefeng Wang
Commit cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()") introduce a wrong logic when write val to LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally. But for !PORT_OCTEON, we better to use coincident write func. Signed-off-by: Kef