Re: [PATCH] serial: 8250: remove return statements from void function

2015-05-25 Thread Greg Kroah-Hartman
On Mon, May 25, 2015 at 10:53:03AM +0900, Masahiro Yamada wrote: > 2015-05-25 4:46 GMT+09:00 Greg Kroah-Hartman : > > On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote: > >> serial8250_set_mctrl() is a void type function. Returning something > >> does not look nice. > >> > >> Signed-

Re: [PATCH] serial: 8250: remove return statements from void function

2015-05-24 Thread Masahiro Yamada
2015-05-25 4:46 GMT+09:00 Greg Kroah-Hartman : > On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote: >> serial8250_set_mctrl() is a void type function. Returning something >> does not look nice. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> drivers/tty/serial/8250/8250_core.c |

Re: [PATCH] serial: 8250: remove return statements from void function

2015-05-24 Thread Greg Kroah-Hartman
On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote: > serial8250_set_mctrl() is a void type function. Returning something > does not look nice. > > Signed-off-by: Masahiro Yamada > --- > > drivers/tty/serial/8250/8250_core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletion

[PATCH] serial: 8250: remove return statements from void function

2015-05-10 Thread Masahiro Yamada
serial8250_set_mctrl() is a void type function. Returning something does not look nice. Signed-off-by: Masahiro Yamada --- drivers/tty/serial/8250/8250_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250