Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-05 Thread Dave Martin
On Tue, May 05, 2015 at 08:11:12PM +0800, Leo Yan wrote: > On Tue, May 05, 2015 at 08:09:27PM +0800, Leo Yan wrote: > > On Tue, May 05, 2015 at 12:11:56PM +0100, Dave P Martin wrote: > > > On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote: > > > [...] > > > > > > Thanks for the fixes, but I

Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-05 Thread Leo Yan
On Tue, May 05, 2015 at 08:09:27PM +0800, Leo Yan wrote: > On Tue, May 05, 2015 at 12:11:56PM +0100, Dave P Martin wrote: > > On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote: > > [...] > > > > Thanks for the fixes, but I already posted patches that probably fix the > > issues you are obser

Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-05 Thread Leo Yan
On Tue, May 05, 2015 at 12:11:56PM +0100, Dave P Martin wrote: > On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote: > [...] > > Thanks for the fixes, but I already posted patches that probably fix the > issues you are observing, And Greg took them into his tty-testing branch. > > Can you gi

Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-05 Thread Dave P Martin
Hi, On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote: > When use pio mode, there have two issues can be observed: > > - In the commit 2240197 "serial/amba-pl011: Leave the TX IRQ alone when > the UART is not open", it will skip clearing the TX IRQ across > pl011_shutdown() and pl011_st

Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-05 Thread Daniel Thompson
On 05/05/15 04:00, Leo Yan wrote: When use pio mode, there have two issues can be observed: - In the commit 2240197 "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open", it will skip clearing the TX IRQ across pl011_shutdown() and pl011_startup(); So at the next time after

[PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-04 Thread Leo Yan
When use pio mode, there have two issues can be observed: - In the commit 2240197 "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open", it will skip clearing the TX IRQ across pl011_shutdown() and pl011_startup(); So at the next time after the uart port has been opened, ther