Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-19 Thread Rafael J. Wysocki
On Wednesday, July 19, 2017 12:24:06 PM Viresh Kumar wrote: > On 18-07-17, 22:34, Leonard Crestez wrote: > > The semantics of scaling_cur_freq and cpuinfo_cur_freq are not very > > clear to me. > > cpuinfo_cur_freq reads the frequency right from hardware all the time > and so can be slow. It can o

Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-18 Thread Viresh Kumar
On 18-07-17, 22:34, Leonard Crestez wrote: > The semantics of scaling_cur_freq and cpuinfo_cur_freq are not very > clear to me. cpuinfo_cur_freq reads the frequency right from hardware all the time and so can be slow. It can only be read by root if I remember correctly. Whereas scaling_cur_freq t

Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-18 Thread Leonard Crestez
On Thu, 2017-07-13 at 14:25 +0530, Viresh Kumar wrote: > On 12-07-17, 14:29, Leonard Crestez wrote: > > > > This checks that the cpufreq driver actually sets the requested > > frequency. > > > > Signed-off-by: Leonard Crestez > > > > --- > > > > I've been looking at using kselftests for imx. T

Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-13 Thread Viresh Kumar
On 12-07-17, 14:29, Leonard Crestez wrote: > This checks that the cpufreq driver actually sets the requested > frequency. > > Signed-off-by: Leonard Crestez > > --- > > I've been looking at using kselftests for imx. This patch exposes an > issue with the imx6 cpufreq driver on imx6sx where freq

Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-12 Thread Rafael J. Wysocki
On Wed, Jul 12, 2017 at 6:51 PM, Leonard Crestez wrote: > On Wed, 2017-07-12 at 13:36 +0200, Rafael J. Wysocki wrote: >> On Wed, Jul 12, 2017 at 1:29 PM, Leonard Crestez >> wrote: >> > >> > This checks that the cpufreq driver actually sets the requested >> > frequency. >> This won't work on moder

Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-12 Thread Leonard Crestez
On Wed, 2017-07-12 at 13:36 +0200, Rafael J. Wysocki wrote: > On Wed, Jul 12, 2017 at 1:29 PM, Leonard Crestez > wrote: > > > > This checks that the cpufreq driver actually sets the requested > > frequency. > This won't work on modern x86  with APERF/MPERF (see recent commits in > that area). Th

Re: [PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-12 Thread Rafael J. Wysocki
On Wed, Jul 12, 2017 at 1:29 PM, Leonard Crestez wrote: > This checks that the cpufreq driver actually sets the requested > frequency. This won't work on modern x86 with APERF/MPERF (see recent commits in that area). Thanks, Rafael

[PATCH] selftests: cpufreq: Check cpuinfo_cur_freq set as expected

2017-07-12 Thread Leonard Crestez
This checks that the cpufreq driver actually sets the requested frequency. Signed-off-by: Leonard Crestez --- I've been looking at using kselftests for imx. This patch exposes an issue with the imx6 cpufreq driver on imx6sx where frequencies are set incorrectly because of clk mishandling. This