Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-12 Thread Jarkko Sakkinen
On Thu, Mar 11, 2021 at 12:53:49PM +0800, Tianjia Zhang wrote: > > > On 3/11/21 11:42 AM, Jarkko Sakkinen wrote: > > On Thu, Mar 11, 2021 at 10:47:50AM +0800, Jia Zhang wrote: > > > > > > > > > On 2021/3/11 上午5:39, Jarkko Sakkinen wrote: > > > > On Wed, Mar 10, 2021 at 08:44:44PM +0800, Jia Zha

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-10 Thread Jia Zhang
On 2021/3/11 上午11:42, Jarkko Sakkinen wrote: > On Thu, Mar 11, 2021 at 10:47:50AM +0800, Jia Zhang wrote: >> >> >> On 2021/3/11 上午5:39, Jarkko Sakkinen wrote: >>> On Wed, Mar 10, 2021 at 08:44:44PM +0800, Jia Zhang wrote: On 2021/3/2 下午9:47, Jarkko Sakkinen wrote: > On Mon, Ma

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-10 Thread Tianjia Zhang
On 3/11/21 11:42 AM, Jarkko Sakkinen wrote: On Thu, Mar 11, 2021 at 10:47:50AM +0800, Jia Zhang wrote: On 2021/3/11 上午5:39, Jarkko Sakkinen wrote: On Wed, Mar 10, 2021 at 08:44:44PM +0800, Jia Zhang wrote: On 2021/3/2 下午9:47, Jarkko Sakkinen wrote: On Mon, Mar 01, 2021 at 09:54:37PM -0

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-10 Thread Jarkko Sakkinen
On Thu, Mar 11, 2021 at 10:47:50AM +0800, Jia Zhang wrote: > > > On 2021/3/11 上午5:39, Jarkko Sakkinen wrote: > > On Wed, Mar 10, 2021 at 08:44:44PM +0800, Jia Zhang wrote: > >> > >> > >> On 2021/3/2 下午9:47, Jarkko Sakkinen wrote: > >>> On Mon, Mar 01, 2021 at 09:54:37PM -0800, Andy Lutomirski wro

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-10 Thread Jia Zhang
On 2021/3/11 上午5:39, Jarkko Sakkinen wrote: > On Wed, Mar 10, 2021 at 08:44:44PM +0800, Jia Zhang wrote: >> >> >> On 2021/3/2 下午9:47, Jarkko Sakkinen wrote: >>> On Mon, Mar 01, 2021 at 09:54:37PM -0800, Andy Lutomirski wrote: On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang wrote: > >

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-10 Thread Jarkko Sakkinen
On Wed, Mar 10, 2021 at 08:44:44PM +0800, Jia Zhang wrote: > > > On 2021/3/2 下午9:47, Jarkko Sakkinen wrote: > > On Mon, Mar 01, 2021 at 09:54:37PM -0800, Andy Lutomirski wrote: > >> On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang > >> wrote: > >>> > >>> > >>> > >>> On 3/1/21 5:54 PM, Jarkko Sakkine

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-10 Thread Jia Zhang
On 2021/3/2 下午9:47, Jarkko Sakkinen wrote: > On Mon, Mar 01, 2021 at 09:54:37PM -0800, Andy Lutomirski wrote: >> On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang >> wrote: >>> >>> >>> >>> On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: >

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-03 Thread Tianjia Zhang
On 3/2/21 8:51 PM, Jarkko Sakkinen wrote: Nit: "due to" Start with capital letter "Fix" Will do in the next patch. On Tue, Mar 02, 2021 at 01:06:52PM +0800, Tianjia Zhang wrote: On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote:

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-03 Thread Tianjia Zhang
On 3/2/21 1:54 PM, Andy Lutomirski wrote: On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang wrote: On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: q2 is not always 384-byte length. Sometimes it only has 383-byte. What does determine

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-02 Thread Jarkko Sakkinen
On Mon, Mar 01, 2021 at 09:54:37PM -0800, Andy Lutomirski wrote: > On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang > wrote: > > > > > > > > On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: > > > On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: > > >> q2 is not always 384-byte length. Sometimes

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-02 Thread Jarkko Sakkinen
Nit: "due to" Start with capital letter "Fix" On Tue, Mar 02, 2021 at 01:06:52PM +0800, Tianjia Zhang wrote: > > > On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: > > On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: > > > q2 is not always 384-byte length. Sometimes it only has 383-byte.

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-02 Thread Andy Lutomirski
On Mon, Mar 1, 2021 at 9:06 PM Tianjia Zhang wrote: > > > > On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: > > On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: > >> q2 is not always 384-byte length. Sometimes it only has 383-byte. > > > > What does determine this? > > > >> In this case, t

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-02 Thread Tianjia Zhang
On 3/1/21 5:54 PM, Jarkko Sakkinen wrote: On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: q2 is not always 384-byte length. Sometimes it only has 383-byte. What does determine this? In this case, the valid portion of q2 is reordered reversely for little endian order, and th

Re: [PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-03-01 Thread Jarkko Sakkinen
On Mon, Mar 01, 2021 at 01:18:36PM +0800, Tianjia Zhang wrote: > q2 is not always 384-byte length. Sometimes it only has 383-byte. What does determine this? > In this case, the valid portion of q2 is reordered reversely for > little endian order, and the remaining portion is filled with zero. I'

[PATCH] selftests/sgx: fix EINIT failure dueto SGX_INVALID_SIGNATURE

2021-02-28 Thread Tianjia Zhang
q2 is not always 384-byte length. Sometimes it only has 383-byte. In this case, the valid portion of q2 is reordered reversely for little endian order, and the remaining portion is filled with zero. Signed-off-by: Tianjia Zhang --- tools/testing/selftests/sgx/sigstruct.c | 41 +--