Re: [PATCH] selftests/sgx: Fix an enclave built with extended instructions

2025-04-09 Thread Vladis Dronov
On Wed, Apr 9, 2025 at 7:07 PM Dave Hansen wrote: > > On 4/9/25 09:55, Vladis Dronov wrote: > ... > > Fix this by adding "-mno-avx" to ENCL_CFLAGS in Makefile. Add some comments > > about this to code locations where enclave's xfrm field is set. > > > > Suggested-by: Dave Hansen > > Signed-off-by

Re: [PATCH] selftests/sgx: Fix an enclave built with extended instructions

2025-04-09 Thread Dave Hansen
On 4/9/25 09:55, Vladis Dronov wrote: ... > Fix this by adding "-mno-avx" to ENCL_CFLAGS in Makefile. Add some comments > about this to code locations where enclave's xfrm field is set. > > Suggested-by: Dave Hansen > Signed-off-by: Vladis Dronov First of all, this looks fine to me: Acked-by: D

[PATCH] selftests/sgx: Fix an enclave built with extended instructions

2025-04-09 Thread Vladis Dronov
Creating an enclave with xfrm == 3 disables extended CPU states and instruction sets, like AVX2 and AVX512 inside the enclave. Thus the enclave code has to be built with a compiler which does not produce instructions from the extended instruction sets. Nevertheless certain Linux distributions confg