Re: [PATCH] selftests/seccomp: Enhance per-arch ptrace syscall skip tests

2019-01-25 Thread shuah
On 1/25/19 11:46 AM, Kees Cook wrote: On Sat, Jan 26, 2019 at 7:42 AM Colin Ian King wrote: On 25/01/2019 18:33, Kees Cook wrote: Passing EPERM during syscall skipping was confusing since the test wasn't actually exercising the errno evaluation -- it was just passing a literal "1" (EPERM). In

Re: [PATCH] selftests/seccomp: Enhance per-arch ptrace syscall skip tests

2019-01-25 Thread Kees Cook
On Sat, Jan 26, 2019 at 7:42 AM Colin Ian King wrote: > > On 25/01/2019 18:33, Kees Cook wrote: > > Passing EPERM during syscall skipping was confusing since the test wasn't > > actually exercising the errno evaluation -- it was just passing a literal > > "1" (EPERM). Instead, expand the tests to

Re: [PATCH] selftests/seccomp: Enhance per-arch ptrace syscall skip tests

2019-01-25 Thread Colin Ian King
On 25/01/2019 18:33, Kees Cook wrote: > Passing EPERM during syscall skipping was confusing since the test wasn't > actually exercising the errno evaluation -- it was just passing a literal > "1" (EPERM). Instead, expand the tests to check both direct value returns > (positive, 45000 in this case),

[PATCH] selftests/seccomp: Enhance per-arch ptrace syscall skip tests

2019-01-25 Thread Kees Cook
Passing EPERM during syscall skipping was confusing since the test wasn't actually exercising the errno evaluation -- it was just passing a literal "1" (EPERM). Instead, expand the tests to check both direct value returns (positive, 45000 in this case), and errno values (negative, -ESRCH in this ca