Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-18 Thread Shuah Khan
On 9/17/20 9:37 PM, Michael Ellerman wrote: Shuah Khan writes: On 9/16/20 10:53 PM, Max Filippov wrote: On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote: The test harness forks() a child to run each test. Both the parent and the child print to stdout using libc functions. That can lea

Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-17 Thread Michael Ellerman
Shuah Khan writes: > On 9/16/20 10:53 PM, Max Filippov wrote: >> On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote: >>> >>> The test harness forks() a child to run each test. Both the parent and >>> the child print to stdout using libc functions. That can lead to >>> duplicated (or more) out

Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-17 Thread Kees Cook
On Thu, Sep 17, 2020 at 02:15:19PM +1000, Michael Ellerman wrote: > The test harness forks() a child to run each test. Both the parent and > the child print to stdout using libc functions. That can lead to > duplicated (or more) output if the libc buffers are not flushed before > forking. > > It's

Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-17 Thread Kees Cook
On Thu, Sep 17, 2020 at 10:51:32AM -0600, Shuah Khan wrote: > On 9/17/20 6:58 AM, Shuah Khan wrote: > > On 9/16/20 10:53 PM, Max Filippov wrote: > > > On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman > > > wrote: > > > > > > > > The test harness forks() a child to run each test. Both the parent a

Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-17 Thread Shuah Khan
On 9/17/20 6:58 AM, Shuah Khan wrote: On 9/16/20 10:53 PM, Max Filippov wrote: On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote: The test harness forks() a child to run each test. Both the parent and the child print to stdout using libc functions. That can lead to duplicated (or more) o

Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-17 Thread Shuah Khan
On 9/16/20 10:53 PM, Max Filippov wrote: On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote: The test harness forks() a child to run each test. Both the parent and the child print to stdout using libc functions. That can lead to duplicated (or more) output if the libc buffers are not flush

Re: [PATCH] selftests/harness: Flush stdout before forking

2020-09-16 Thread Max Filippov
On Wed, Sep 16, 2020 at 9:16 PM Michael Ellerman wrote: > > The test harness forks() a child to run each test. Both the parent and > the child print to stdout using libc functions. That can lead to > duplicated (or more) output if the libc buffers are not flushed before > forking. > > It's general

[PATCH] selftests/harness: Flush stdout before forking

2020-09-16 Thread Michael Ellerman
The test harness forks() a child to run each test. Both the parent and the child print to stdout using libc functions. That can lead to duplicated (or more) output if the libc buffers are not flushed before forking. It's generally not seen when running programs directly, because stdout will usuall