Re: [PATCH] selftest: add a test case to check how locks are shown in fdinfo

2015-03-13 Thread Shuah Khan
On 03/13/2015 03:34 AM, Andrew Vagin wrote: > On Thu, Mar 12, 2015 at 02:43:19PM -0600, Shuah Khan wrote: >> Hi Andrey, >> >> Looks good in general. Couple of comments. > > Thanks. The updated version is attached. Please send a properly marked patch v2. Please don't send patches as attachments.

Re: [PATCH] selftest: add a test case to check how locks are shown in fdinfo

2015-03-13 Thread Andrew Vagin
> > + if (strncmp(p, "lock:", 5)) > > + continue; > > + ret = sscanf(p, "lock:\t%d:%s %s %s %d %x:%x:%ld %lld %s", > > + &fl_id, fl_flag, fl_type, fl_option, > > +

Re: [PATCH] selftest: add a test case to check how locks are shown in fdinfo

2015-03-12 Thread Shuah Khan
Hi Andrey, Looks good in general. Couple of comments. On 03/12/2015 10:30 AM, Andrey Vagin wrote: > The main idea of this test is to check that locks are shown correctly > when they can't be placed in a default seq_file buffer due to its size. > > Cc: Andrew Morton > Cc: Shuah Khan > Signed-of

[PATCH] selftest: add a test case to check how locks are shown in fdinfo

2015-03-12 Thread Andrey Vagin
The main idea of this test is to check that locks are shown correctly when they can't be placed in a default seq_file buffer due to its size. Cc: Andrew Morton Cc: Shuah Khan Signed-off-by: Andrey Vagin --- tools/testing/selftests/Makefile| 1 + tools/testing/selftests/fdinfo/Makefil