Re: [PATCH] security: keys: Use kvfree_sensitive in a few places

2020-09-14 Thread Jarkko Sakkinen
On Fri, Sep 11, 2020 at 07:05:16PM +0300, Denis Efremov wrote: > Hi, > > same patch > > https://lkml.org/lkml/2020/8/27/168 > > Thanks, > Denis David, can you pick this up? /Jarkko

Re: [PATCH] security: keys: Use kvfree_sensitive in a few places

2020-09-11 Thread James Bottomley
On Fri, 2020-09-11 at 12:44 +0100, Alex Dewar wrote: > In big_key.c, there are a few places where memzero_explicit + kvfree > is used. It is better to use kvfree_sensitive instead, which is more > readable and also prevents the compiler from eliding the call to > memzero_explicit. Fix this. That l

Re: [PATCH] security: keys: Use kvfree_sensitive in a few places

2020-09-11 Thread Alex Dewar
On 2020-09-11 17:05, Denis Efremov wrote: Hi, same patch https://lkml.org/lkml/2020/8/27/168 Thanks, Denis Ah ok. Sorry for the noise! On 9/11/20 2:44 PM, Alex Dewar wrote: In big_key.c, there are a few places where memzero_explicit + kvfree is used. It is better to use kvfree_sensitive in

Re: [PATCH] security: keys: Use kvfree_sensitive in a few places

2020-09-11 Thread Denis Efremov
Hi, same patch https://lkml.org/lkml/2020/8/27/168 Thanks, Denis On 9/11/20 2:44 PM, Alex Dewar wrote: > In big_key.c, there are a few places where memzero_explicit + kvfree is > used. It is better to use kvfree_sensitive instead, which is more > readable and also prevents the compiler from eli

[PATCH] security: keys: Use kvfree_sensitive in a few places

2020-09-11 Thread Alex Dewar
In big_key.c, there are a few places where memzero_explicit + kvfree is used. It is better to use kvfree_sensitive instead, which is more readable and also prevents the compiler from eliding the call to memzero_explicit. Fix this. Signed-off-by: Alex Dewar --- security/keys/big_key.c | 9 +++

Re: [PATCH] security/keys: use kvfree_sensitive()

2020-08-27 Thread Jarkko Sakkinen
On Thu, Aug 27, 2020 at 10:29:23AM +0300, Denis Efremov wrote: > Use kvfree_sensitive() instead of open-coding it. > > Signed-off-by: Denis Efremov Reviewed-by: Jarkko Sakkinen /Jarkko

[PATCH] security/keys: use kvfree_sensitive()

2020-08-27 Thread Denis Efremov
Use kvfree_sensitive() instead of open-coding it. Signed-off-by: Denis Efremov --- security/keys/big_key.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/security/keys/big_key.c b/security/keys/big_key.c index 691347dea3c1..d17e5f09eeb8 100644 --- a/security/keys/bi