Re: [PATCH] seccomp: don't leave dangling ->notif if file allocation fails

2020-09-08 Thread Kees Cook
On Wed, 2 Sep 2020 08:09:53 -0600, Tycho Andersen wrote: > Christian and Kees both pointed out that this is a bit sloppy to open-code > both places, and Christian points out that we leave a dangling pointer to > ->notif if file allocation fails. Since we check ->notif for null in order > to determi

[PATCH] seccomp: don't leave dangling ->notif if file allocation fails

2020-09-02 Thread Tycho Andersen
Christian and Kees both pointed out that this is a bit sloppy to open-code both places, and Christian points out that we leave a dangling pointer to ->notif if file allocation fails. Since we check ->notif for null in order to determine if it's ok to install a filter, this means people won't be abl

Re: [PATCH] seccomp: don't leave dangling ->notif if file allocation fails

2020-09-02 Thread Christian Brauner
On Wed, Sep 02, 2020 at 08:09:53AM -0600, Tycho Andersen wrote: > Christian and Kees both pointed out that this is a bit sloppy to open-code > both places, and Christian points out that we leave a dangling pointer to > ->notif if file allocation fails. Since we check ->notif for null in order > to