Re: [PATCH] sdhci: fix the fake timeout bug

2018-12-04 Thread Adrian Hunter
On 1/12/18 7:42 AM, Du, Alek wrote: > On Fri, 30 Nov 2018 16:40:04 +0200 > Adrian Hunter wrote: > >> So you are saying this only happens under virtualization? >> > > Yes, I saw the issue under ACRN virtualization Service OS (4.19 kernel). > But theoretically it can happen in other case when sche

Re: [PATCH] sdhci: fix the fake timeout bug

2018-11-30 Thread Du, Alek
On Fri, 30 Nov 2018 16:40:04 +0200 Adrian Hunter wrote: > So you are saying this only happens under virtualization? > Yes, I saw the issue under ACRN virtualization Service OS (4.19 kernel). But theoretically it can happen in other case when scheduling is not that good. (due to bad driver or ot

Re: [PATCH] sdhci: fix the fake timeout bug

2018-11-30 Thread Adrian Hunter
On 30/11/18 4:13 PM, Du, Alek wrote: > On Fri, 30 Nov 2018 11:19:03 +0200 > Adrian Hunter wrote: > >> Commands and resets are under spin lock, so no possibility for >> preemption, and certainly a few microseconds isn't going to make any >> difference to these timeouts, so I don't see how this pat

Re: [PATCH] sdhci: fix the fake timeout bug

2018-11-30 Thread Du, Alek
On Fri, 30 Nov 2018 11:19:03 +0200 Adrian Hunter wrote: > Commands and resets are under spin lock, so no possibility for > preemption, and certainly a few microseconds isn't going to make any > difference to these timeouts, so I don't see how this patch could > help. Thanks for your review. I b

Re: [PATCH] sdhci: fix the fake timeout bug

2018-11-30 Thread Adrian Hunter
On 30/11/18 9:00 AM, Du, Alek wrote: >>From b893df3a1a937bd5fe22d39ceae93454a2e5e0e4 Mon Sep 17 00:00:00 2001 > From: Alek Du > Date: Fri, 30 Nov 2018 14:02:28 +0800 > Subject: [PATCH] sdhci: fix the fake timeout bug > > We observed some fake timeouts on some devices,

[PATCH] sdhci: fix the fake timeout bug

2018-11-29 Thread Du, Alek
>From b893df3a1a937bd5fe22d39ceae93454a2e5e0e4 Mon Sep 17 00:00:00 2001 From: Alek Du Date: Fri, 30 Nov 2018 14:02:28 +0800 Subject: [PATCH] sdhci: fix the fake timeout bug We observed some fake timeouts on some devices, the log is like this: [ 7586.290201] mmc1: Timeout waiting for hardw