Re: [PATCH] sctp: Remove some redundant code

2016-09-15 Thread Marcelo
On Thu, Sep 15, 2016 at 09:32:18PM +0200, Christophe JAILLET wrote: > Le 15/09/2016 à 19:34, Marcelo a écrit : > > On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote: > > > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call > > > to 'skb_queue_splice_tail_ini

Re: [PATCH] sctp: Remove some redundant code

2016-09-15 Thread Christophe JAILLET
Le 15/09/2016 à 19:34, Marcelo a écrit : On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote: In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was hidden in 'sctp_skb_list_tail()' No

Re: [PATCH] sctp: Remove some redundant code

2016-09-15 Thread Marcelo
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote: > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was > hidden in 'sctp_skb_list_tail()' > > Now, the code around it looks redund

Re: [PATCH] sctp: Remove some redundant code

2016-09-07 Thread Neil Horman
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote: > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was > hidden in 'sctp_skb_list_tail()' > > Now, the code around it looks redund

Re: [PATCH] sctp: Remove some redundant code

2016-09-05 Thread marcelo . leitner
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote: > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was > hidden in 'sctp_skb_list_tail()' > > Now, the code around it looks redund

Re: [PATCH] sctp: Remove some redundant code

2016-09-05 Thread marcelo . leitner
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote: > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was > hidden in 'sctp_skb_list_tail()' > > Now, the code around it looks redund

[PATCH] sctp: Remove some redundant code

2016-09-04 Thread Christophe JAILLET
In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was hidden in 'sctp_skb_list_tail()' Now, the code around it looks redundant. The '_init()' part of 'skb_queue_splice_tail_init()' should alreday do th