Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-25 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> do_div is the wrong way to divide a sector_t, as it is less Arnd> efficient when sector_t is 32-bit wide. With the upcoming do_div Arnd> optimizations, the kernel starts warning about this: Applied. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-24 Thread Hannes Reinecke
On 11/20/2015 05:38 PM, Arnd Bergmann wrote: > do_div is the wrong way to divide a sector_t, as it is less > efficient when sector_t is 32-bit wide. With the upcoming > do_div optimizations, the kernel starts warning about this: > > drivers/scsi/scsi_debug.c: In function 'dif_store': > include/asm

Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-24 Thread Sagi Grimberg
On 20/11/2015 18:38, Arnd Bergmann wrote: do_div is the wrong way to divide a sector_t, as it is less efficient when sector_t is 32-bit wide. With the upcoming do_div optimizations, the kernel starts warning about this: drivers/scsi/scsi_debug.c: In function 'dif_store': include/asm-generic/di

Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-24 Thread Johannes Thumshirn
On Fri, 2015-11-20 at 17:38 +0100, Arnd Bergmann wrote: > do_div is the wrong way to divide a sector_t, as it is less > efficient when sector_t is 32-bit wide. With the upcoming > do_div optimizations, the kernel starts warning about this: > > drivers/scsi/scsi_debug.c: In function 'dif_store': >

[PATCH] scsi: use sector_div instead of do_div

2015-11-20 Thread Arnd Bergmann
do_div is the wrong way to divide a sector_t, as it is less efficient when sector_t is 32-bit wide. With the upcoming do_div optimizations, the kernel starts warning about this: drivers/scsi/scsi_debug.c: In function 'dif_store': include/asm-generic/div64.h:207:28: warning: comparison of distinct