Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-09-29 Thread Alim Akhtar
Hi Martin, On 09/26/2017 01:01 AM, Martin K. Petersen wrote: > > Alim, > >> Should I drop this patch and send another one which removes UFS_BIT() >> macro? > > I fail to see the point of UFS_BIT(). So yes. > > Please make sure to CC: Subhash on ufs changes. > Thanks for looking into this patc

Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-09-25 Thread Martin K. Petersen
Alim, > Should I drop this patch and send another one which removes UFS_BIT() > macro? I fail to see the point of UFS_BIT(). So yes. Please make sure to CC: Subhash on ufs changes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-09-10 Thread Alim Akhtar
Hi, Ping!!! Should I drop this patch and send another one which removes UFS_BIT() macro? On Tue, Aug 29, 2017 at 4:35 PM, Alim Akhtar wrote: > Hi Bart, > Thanks for your review. > > On 08/28/2017 09:15 PM, Bart Van Assche wrote: >> On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote: >>> This

Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-08-29 Thread Alim Akhtar
Hi Bart, Thanks for your review. On 08/28/2017 09:15 PM, Bart Van Assche wrote: > On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote: >> This entire file uses UFS_BIT macro for bits definition, expect for few >> places. This patch convert those defines to use UFS_BIT macro to be aligned >> with

Re: [PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-08-28 Thread Bart Van Assche
On Mon, 2017-08-28 at 17:49 +0530, Alim Akhtar wrote: > This entire file uses UFS_BIT macro for bits definition, expect for few > places. This patch convert those defines to use UFS_BIT macro to be aligned > with reset of the file. This is the definition of the UFS_BIT() macro I found in drivers/s

[PATCH] scsi: ufs: Make use of UFS_BIT macro wherever possible

2017-08-28 Thread Alim Akhtar
This entire file uses UFS_BIT macro for bits definition, expect for few places. This patch convert those defines to use UFS_BIT macro to be aligned with reset of the file. Signed-off-by: Alim Akhtar --- drivers/scsi/ufs/ufshci.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -