Re: [PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
On Feb 9, 2008 7:00 AM, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-09 at 04:13 -0800, Yinghai Lu wrote: > > [PATCH] scsi: ses fix for len and mem leaking when fail to add intf > > > > change to u32 before left shifting char > > This one is

Re: [PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 04:13 -0800, Yinghai Lu wrote: > [PATCH] scsi: ses fix for len and mem leaking when fail to add intf > > change to u32 before left shifting char This one is a bit unnecessary; C promotion rules guarantee that everything is promoted to int (or above) before doing a

[PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
[PATCH] scsi: ses fix for len and mem leaking when fail to add intf change to u32 before left shifting char also fix leaking with scomp leaking when failing. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi