Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

2019-02-12 Thread Xuewei Zhang
Thanks for the fix James! On Tue, Feb 12, 2019 at 8:59 AM Martin K. Petersen wrote: > > > Jens, > > >> The fix is to set the non-rotational and add-randomness flags > >> unconditionally early on in the disk initialization path, so they can > >> be reset only if the device actually reports being n

Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

2019-02-12 Thread Martin K. Petersen
Jens, >> The fix is to set the non-rotational and add-randomness flags >> unconditionally early on in the disk initialization path, so they can >> be reset only if the device actually reports being non-rotational via >> the VPD page. > > Reviewed-by: Jens Axboe Yeah, this looks good to me. I'l

Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

2019-02-12 Thread Jens Axboe
On 2/12/19 9:05 AM, James Bottomley wrote: > The problem is that the default for MQ is not to gather entropy, > whereas the default for the legacy queue was always to gather it. The > original attempt to fix entropy gathering for rotational disks under MQ > added an else branch in sd_read_block_ch

[PATCH] scsi: sd: fix entropy gathering for most rotational disks

2019-02-12 Thread James Bottomley
The problem is that the default for MQ is not to gather entropy, whereas the default for the legacy queue was always to gather it. The original attempt to fix entropy gathering for rotational disks under MQ added an else branch in sd_read_block_characteristics(). Unfortunately, the entire check i