Re: [PATCH] scsi: hisi_sas: select CONFIG_RAS

2017-11-03 Thread Martin K. Petersen
John, > Actually this interface is intended for logging UEFI CPER non-standard > records from kernel RAS/APEI framework to userspace. It is not intended > for kernel peripheral driver logging (like this case). Until we get a > community concensus on whether this is acceptable, I would rather reve

Re: [PATCH] scsi: hisi_sas: select CONFIG_RAS

2017-11-03 Thread John Garry
On 03/11/2017 10:19, Arnd Bergmann wrote: On Fri, Nov 3, 2017 at 11:14 AM, John Garry wrote: + Shiju, who authored the original patch index d42f29a5eb65..6ad8a6251d21 100644 --- a/drivers/scsi/hisi_sas/Kconfig +++ b/drivers/scsi/hisi_sas/Kconfig @@ -4,6 +4,7 @@ config SCSI_HISI_SAS

Re: [PATCH] scsi: hisi_sas: select CONFIG_RAS

2017-11-03 Thread Arnd Bergmann
On Fri, Nov 3, 2017 at 11:14 AM, John Garry wrote: > + Shiju, who authored the original patch > >> index d42f29a5eb65..6ad8a6251d21 100644 >> --- a/drivers/scsi/hisi_sas/Kconfig >> +++ b/drivers/scsi/hisi_sas/Kconfig >> @@ -4,6 +4,7 @@ config SCSI_HISI_SAS >> depends on ARM64 || COMPILE_T

Re: [PATCH] scsi: hisi_sas: select CONFIG_RAS

2017-11-03 Thread John Garry
+ Shiju, who authored the original patch Hi Arnd, Thanks for this. On 02/11/2017 16:50, Arnd Bergmann wrote: The driver now uses the RAS infrastructure, and fails to link if that is disabled: drivers/scsi/hisi_sas/hisi_sas_v2_hw.o: In function `fatal_ecc_int_v2_hw': hisi_sas_v2_hw.c:(.text+0x

[PATCH] scsi: hisi_sas: select CONFIG_RAS

2017-11-02 Thread Arnd Bergmann
The driver now uses the RAS infrastructure, and fails to link if that is disabled: drivers/scsi/hisi_sas/hisi_sas_v2_hw.o: In function `fatal_ecc_int_v2_hw': hisi_sas_v2_hw.c:(.text+0xb08): undefined reference to `__tracepoint_non_standard_event' drivers/scsi/hisi_sas/hisi_sas_v2_hw.o: In functio