Re: [PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

2017-09-25 Thread Johannes Thumshirn
On Mon, Sep 25, 2017 at 11:29:07PM +, Bart Van Assche wrote: > Did you perhaps intend to use WARN_ON_ONCE() instead of WARN_ON()? Now that you're saying it. I'll send a v2. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

2017-09-25 Thread Bart Van Assche
On Mon, 2017-09-25 at 14:00 +0200, Johannes Thumshirn wrote: > Coverity-scan recently found a possible NULL pointer dereference in > fc_block_scsi_eh() as starget_to_rport() either returns the rport for > the startget or NULL. > > While it is rather unlikely to have fc_block_scsi_eh() called witho

[PATCH] scsi: fc: check for rport presence in fc_block_scsi_eh

2017-09-25 Thread Johannes Thumshirn
Coverity-scan recently found a possible NULL pointer dereference in fc_block_scsi_eh() as starget_to_rport() either returns the rport for the startget or NULL. While it is rather unlikely to have fc_block_scsi_eh() called without an rport associated it's a good idea to catch potential misuses of t