Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons

James, > I also don't really think the replacement adds anything to readability, > so it should probably be removed from the checkpatch warnings. I agree. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons

On Thu, 2019-07-11 at 19:48 -0400, Keyur Patel wrote: > Change (x == NULL) to !x and (x != NULL) to x, to fix > following checkpatch.pl warnings: > CHECK: Comparison to NULL could be written "!x". This is one of our significantly older drivers. We try not to touch it unless we really have to, so

[PATCH] scsi: aha1740: Use !x in place of NULL comparisons

Change (x == NULL) to !x and (x != NULL) to x, to fix following checkpatch.pl warnings: CHECK: Comparison to NULL could be written "!x". Signed-off-by: Keyur Patel --- drivers/scsi/aha1740.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aha1740.c b/drivers/