Re: [PATCH] scsi: Avoid potential infinite eh_timeout_handler() loop

2015-06-04 Thread Rajat Jain
Hello James, On Thu, Jun 4, 2015 at 1:27 PM, James Bottomley wrote: > On Thu, 2015-06-04 at 11:40 -0700, Rajat Jain wrote: >> Each cmd timeout should result in scmd->retries++. Currently it happens >> just only before a command is requeued back. However, if the LLD >> eh_timed_out() handler asks

Re: [PATCH] scsi: Avoid potential infinite eh_timeout_handler() loop

2015-06-04 Thread James Bottomley
On Thu, 2015-06-04 at 11:40 -0700, Rajat Jain wrote: > Each cmd timeout should result in scmd->retries++. Currently it happens > just only before a command is requeued back. However, if the LLD > eh_timed_out() handler asks to reset timer back again, then also it should > be incremented because eff

[PATCH] scsi: Avoid potential infinite eh_timeout_handler() loop

2015-06-04 Thread Rajat Jain
Each cmd timeout should result in scmd->retries++. Currently it happens just only before a command is requeued back. However, if the LLD eh_timed_out() handler asks to reset timer back again, then also it should be incremented because effectively LLD will be given a full time period (SD_TIMEOUT = 3