Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-09 Thread Santosh Shilimkar
On Wednesday 09 October 2013 07:59 PM, John Stultz wrote: > On 10/02/2013 11:07 AM, Santosh Shilimkar wrote: >> On Wednesday 02 October 2013 01:48 PM, Will Deacon wrote: >>> On Wed, Oct 02, 2013 at 06:42:40PM +0100, Stephen Boyd wrote: On 10/02/13 10:27, Santosh Shilimkar wrote: > Really..

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-09 Thread John Stultz
On 10/02/2013 11:07 AM, Santosh Shilimkar wrote: > On Wednesday 02 October 2013 01:48 PM, Will Deacon wrote: >> On Wed, Oct 02, 2013 at 06:42:40PM +0100, Stephen Boyd wrote: >>> On 10/02/13 10:27, Santosh Shilimkar wrote: Really... I have not created patch out of fun. Its broken on my key

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Rob Herring
On Wed, Oct 2, 2013 at 12:42 PM, Stephen Boyd wrote: > On 10/02/13 10:27, Santosh Shilimkar wrote: >> On Wednesday 02 October 2013 01:22 PM, Stephen Boyd wrote: >>> On 10/02/13 10:14, Santosh Shilimkar wrote: On Wednesday 02 October 2013 01:09 PM, Will Deacon wrote: > On Wed, Oct 02, 2013

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Santosh Shilimkar
On Wednesday 02 October 2013 01:48 PM, Will Deacon wrote: > On Wed, Oct 02, 2013 at 06:42:40PM +0100, Stephen Boyd wrote: >> On 10/02/13 10:27, Santosh Shilimkar wrote: >>> Really... I have not created patch out of fun. >>> Its broken on my keystone machine at least where the sched_clock is >>> fal

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Will Deacon
On Wed, Oct 02, 2013 at 06:42:40PM +0100, Stephen Boyd wrote: > On 10/02/13 10:27, Santosh Shilimkar wrote: > > Really... I have not created patch out of fun. > > Its broken on my keystone machine at least where the sched_clock is > > falling back on jiffy based sched_clock even in presence of arch

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Stephen Boyd
On 10/02/13 10:27, Santosh Shilimkar wrote: > On Wednesday 02 October 2013 01:22 PM, Stephen Boyd wrote: >> On 10/02/13 10:14, Santosh Shilimkar wrote: >>> On Wednesday 02 October 2013 01:09 PM, Will Deacon wrote: On Wed, Oct 02, 2013 at 05:55:28PM +0100, Santosh Shilimkar wrote: > The sch

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Santosh Shilimkar
On Wednesday 02 October 2013 01:22 PM, Stephen Boyd wrote: > On 10/02/13 10:14, Santosh Shilimkar wrote: >> On Wednesday 02 October 2013 01:09 PM, Will Deacon wrote: >>> On Wed, Oct 02, 2013 at 05:55:28PM +0100, Santosh Shilimkar wrote: The sched_clock code uses 2 levels of function pointers,

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Stephen Boyd
On 10/02/13 10:14, Santosh Shilimkar wrote: > On Wednesday 02 October 2013 01:09 PM, Will Deacon wrote: >> On Wed, Oct 02, 2013 at 05:55:28PM +0100, Santosh Shilimkar wrote: >>> The sched_clock code uses 2 levels of function pointers, sched_clock_func() >>> and read_sched_clock() but the no sched_c

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Santosh Shilimkar
On Wednesday 02 October 2013 01:09 PM, Will Deacon wrote: > On Wed, Oct 02, 2013 at 05:55:28PM +0100, Santosh Shilimkar wrote: >> The sched_clock code uses 2 levels of function pointers, sched_clock_func() >> and read_sched_clock() but the no sched_clock check in postinit() just >> checks read_sche

Re: [PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Will Deacon
On Wed, Oct 02, 2013 at 05:55:28PM +0100, Santosh Shilimkar wrote: > The sched_clock code uses 2 levels of function pointers, sched_clock_func() > and read_sched_clock() but the no sched_clock check in postinit() just > checks read_sched_clock(). > > This leads to kernel falling back to jiffy base

[PATCH] sched_clock: fix postinit no sched_clock function check

2013-10-02 Thread Santosh Shilimkar
The sched_clock code uses 2 levels of function pointers, sched_clock_func() and read_sched_clock() but the no sched_clock check in postinit() just checks read_sched_clock(). This leads to kernel falling back to jiffy based sched clock even in presence of sched_clock_func() which is not desirable.