Re: [PATCH] sched: update last_balance only when actually balanced

2014-07-22 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2014 08:04 AM, Peter Zijlstra wrote: >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index >> 45943b2..4f7fee2 100644 --- a/kernel/sched/fair.c +++ >> b/kernel/sched/fair.c @@ -7187,7 +7187,9 @@ static void >> rebalance_domains(stru

Re: [PATCH] sched: update last_balance only when actually balanced

2014-07-22 Thread Peter Zijlstra
On Tue, Jul 22, 2014 at 02:21:21AM -0400, Rik van Riel wrote: > Currently rebalance_domains will happily update sd->last_balance > even if should_we_balance() decides that this CPU should not do > any load balancing for the sd. > > This can prevent the CPU that should load balance for the sd from

[PATCH] sched: update last_balance only when actually balanced

2014-07-21 Thread Rik van Riel
Currently rebalance_domains will happily update sd->last_balance even if should_we_balance() decides that this CPU should not do any load balancing for the sd. This can prevent the CPU that should load balance for the sd from doing load balancing, which can delay active balancing essentially forev