Re: [PATCH] sched: unlikely corrupted stack end

2016-06-14 Thread Peter Zijlstra
On Tue, Jun 14, 2016 at 02:43:06PM +0800, WANG Chao wrote: > unlikely() was dropped in commit ce03e41 ("sched/core: Drop unlikely > behind BUG_ON()"), but commit 29d6455 ("sched: panic on corrupted stack > end") dropped BUG_ON() and called panic directly. Please use git config core.abbrev=12 and t

Re: [PATCH] sched: unlikely corrupted stack end

2016-06-14 Thread Ingo Molnar
* WANG Chao wrote: > unlikely() was dropped in commit ce03e41 ("sched/core: Drop unlikely > behind BUG_ON()"), but commit 29d6455 ("sched: panic on corrupted stack > end") dropped BUG_ON() and called panic directly. > > Now we should bring unlikely() back for branch prediction. > > Signed-off-

[PATCH] sched: unlikely corrupted stack end

2016-06-13 Thread WANG Chao
unlikely() was dropped in commit ce03e41 ("sched/core: Drop unlikely behind BUG_ON()"), but commit 29d6455 ("sched: panic on corrupted stack end") dropped BUG_ON() and called panic directly. Now we should bring unlikely() back for branch prediction. Signed-off-by: WANG Chao --- kernel/sched/cor