Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Peter Zijlstra
On Mon, 2008-02-25 at 21:31 +0530, Srivatsa Vaddagiri wrote: > On Mon, Feb 25, 2008 at 04:28:02PM +0100, Peter Zijlstra wrote: > > Vatsa, would it make sense to take just that out, or just do a full > > revert? > > Peter, > 6b2d7700266b9402e12824e11e0099ae6a4a6a79 and > 58e2d4ca581167c2a07

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Srivatsa Vaddagiri
On Mon, Feb 25, 2008 at 04:28:02PM +0100, Peter Zijlstra wrote: > Vatsa, would it make sense to take just that out, or just do a full > revert? Peter, 6b2d7700266b9402e12824e11e0099ae6a4a6a79 and 58e2d4ca581167c2a079f4ee02be2f0bc52e8729 are related very much. The later changes how cpu loa

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Heiko Carstens
On Mon, Feb 25, 2008 at 04:28:02PM +0100, Peter Zijlstra wrote: > On Mon, 2008-02-25 at 20:05 +0530, Dhaval Giani wrote: > Subject: sched: fully revert load_balance_monitor() > > The following commit causes a number of serious regressions: > > commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79 >

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Peter Zijlstra
On Mon, 2008-02-25 at 20:05 +0530, Dhaval Giani wrote: > This is funny. The thread should not start. Did the full revert that I > sent you sometime back work better? I suspect it are the change in sched_fair.c:load_balance_fair(). I assumed those were to handle the case where tg->share != cpu sh

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Mike Galbraith
On Mon, 2008-02-25 at 20:05 +0530, Dhaval Giani wrote: > This is funny. The thread should not start. Did the full revert that I > sent you sometime back work better? Yes. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Dhaval Giani
On Mon, Feb 25, 2008 at 03:29:59PM +0100, Mike Galbraith wrote: > > On Mon, 2008-02-25 at 13:22 +0100, Peter Zijlstra wrote: > > Subject: sched: revert load_balance_monitor() > > > > The following commit causes a number of serious regressions: > > > > commit 6b2d7700266b9402e12824e11e0099ae6a4

Re: [PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Mike Galbraith
On Mon, 2008-02-25 at 13:22 +0100, Peter Zijlstra wrote: > Subject: sched: revert load_balance_monitor() > > The following commit causes a number of serious regressions: > > commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79 > Author: Srivatsa Vaddagiri <[EMAIL PROTECTED]> > Date: Fri Jan 2

[PATCH] sched: revert load_balance_monitor()

2008-02-25 Thread Peter Zijlstra
Subject: sched: revert load_balance_monitor() The following commit causes a number of serious regressions: commit 6b2d7700266b9402e12824e11e0099ae6a4a6a79 Author: Srivatsa Vaddagiri <[EMAIL PROTECTED]> Date: Fri Jan 25 21:08:00 2008 +0100 sched: group scheduler, fix fairness of cpu band