Re: [PATCH] sched: Update unlikely to now likely in sched_move_task()

2017-02-04 Thread Steven Rostedt
On Sat, 4 Feb 2017 12:06:45 +0100 Peter Zijlstra wrote: > I prefer to simply remove the hint entirely and match all the other > instances of this pattern. Perhaps just remove the hint then. I'll update the patch. > > Now if only C wouldn't stink and have a sensible way to express this > patter

Re: [PATCH] sched: Update unlikely to now likely in sched_move_task()

2017-02-04 Thread Peter Zijlstra
On Fri, Feb 03, 2017 at 03:30:19PM -0500, Steven Rostedt (VMware) wrote: > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index c56fb57..669f23d 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -7989,14 +7989,14 @@ void sched_move_task(struct task_struct *tsk) > >

[PATCH] sched: Update unlikely to now likely in sched_move_task()

2017-02-03 Thread Steven Rostedt (VMware)
From: "Steven Rostedt (VMware)" The check for running in sched_move_task() has an unlikely() around it. That is, it is unlikely that the task being moved is running. That use to be true. But with a couple of recent updates, it is now likely that the task will be running. The first change came fr