Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-09 Thread Rafael J. Wysocki
On Wed, May 9, 2018 at 11:30 AM, Viresh Kumar wrote: > On 09-05-18, 11:23, Rafael J. Wysocki wrote: >> On Wed, May 9, 2018 at 11:15 AM, Viresh Kumar >> wrote: >> > On 09-05-18, 10:56, Rafael J. Wysocki wrote: >> >> I'm kind of concerned about updating the limits via sysfs in which >> >> case the

Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-09 Thread Viresh Kumar
On 09-05-18, 11:23, Rafael J. Wysocki wrote: > On Wed, May 9, 2018 at 11:15 AM, Viresh Kumar wrote: > > On 09-05-18, 10:56, Rafael J. Wysocki wrote: > >> I'm kind of concerned about updating the limits via sysfs in which > >> case the cached next frequency may be out of range, so it's better to >

Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-09 Thread Rafael J. Wysocki
On Wed, May 9, 2018 at 11:15 AM, Viresh Kumar wrote: > On 09-05-18, 10:56, Rafael J. Wysocki wrote: >> I'm kind of concerned about updating the limits via sysfs in which >> case the cached next frequency may be out of range, so it's better to >> invalidate it right away then. > > That should not b

Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-09 Thread Viresh Kumar
On 09-05-18, 10:56, Rafael J. Wysocki wrote: > I'm kind of concerned about updating the limits via sysfs in which > case the cached next frequency may be out of range, so it's better to > invalidate it right away then. That should not be a problem as __cpufreq_driver_target() will anyway clamp the

Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-09 Thread Rafael J. Wysocki
On Wed, May 9, 2018 at 10:41 AM, Viresh Kumar wrote: > On 08-05-18, 22:54, Rafael J. Wysocki wrote: >> On Tue, May 8, 2018 at 8:42 AM, Viresh Kumar wrote: >> > The schedutil driver sets sg_policy->next_freq to UINT_MAX on certain >> > occasions: >> > - In sugov_start(), when the schedutil governo

Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-09 Thread Viresh Kumar
On 08-05-18, 22:54, Rafael J. Wysocki wrote: > On Tue, May 8, 2018 at 8:42 AM, Viresh Kumar wrote: > > The schedutil driver sets sg_policy->next_freq to UINT_MAX on certain > > occasions: > > - In sugov_start(), when the schedutil governor is started for a group > > of CPUs. > > - And whenever w

Re: [PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-08 Thread Rafael J. Wysocki
On Tue, May 8, 2018 at 8:42 AM, Viresh Kumar wrote: > The schedutil driver sets sg_policy->next_freq to UINT_MAX on certain > occasions: > - In sugov_start(), when the schedutil governor is started for a group > of CPUs. > - And whenever we need to force a freq update before rate-limit > durat

[PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-07 Thread Viresh Kumar
The schedutil driver sets sg_policy->next_freq to UINT_MAX on certain occasions: - In sugov_start(), when the schedutil governor is started for a group of CPUs. - And whenever we need to force a freq update before rate-limit duration, which happens when: - there is an update in cpufreq policy