Re: [PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-22 Thread Vincent Guittot
On Sat, 20 Mar 2021 at 23:21, Barry Song wrote: > > update_idle_core() is only done for the case of sched_smt_present. > but test_idle_cores() is done for all machines even those without > smt. > this could contribute to up 8%+ hackbench performance loss on a > machine like kunpeng 920 which has n

Re: [PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-22 Thread Peter Zijlstra
On Sun, Mar 21, 2021 at 11:14:32AM +1300, Barry Song wrote: > update_idle_core() is only done for the case of sched_smt_present. > but test_idle_cores() is done for all machines even those without > smt. > this could contribute to up 8%+ hackbench performance loss on a > machine like kunpeng 920 wh

Re: [PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-22 Thread Mel Gorman
On Sun, Mar 21, 2021 at 11:14:32AM +1300, Barry Song wrote: > update_idle_core() is only done for the case of sched_smt_present. > but test_idle_cores() is done for all machines even those without > smt. > this could contribute to up 8%+ hackbench performance loss on a > machine like kunpeng 920 wh

RE: [Linuxarm] Re: [PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-21 Thread Song Bao Hua (Barry Song)
ject: [Linuxarm] Re: [PATCH] sched/fair: remove redundant test_idle_cores > for non-smt > > Hi Barry, > > On 2021/3/21 6:14, Barry Song wrote: > > update_idle_core() is only done for the case of sched_smt_present. > > but test_idle_cores() is done for all machines ev

Re: [PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-21 Thread Li, Aubrey
Hi Barry, On 2021/3/21 6:14, Barry Song wrote: > update_idle_core() is only done for the case of sched_smt_present. > but test_idle_cores() is done for all machines even those without > smt. The patch looks good to me. May I know for what case we need to keep CONFIG_SCHED_SMT for non-smt machines

[PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-20 Thread Barry Song
update_idle_core() is only done for the case of sched_smt_present. but test_idle_cores() is done for all machines even those without smt. this could contribute to up 8%+ hackbench performance loss on a machine like kunpeng 920 which has no smt. this patch removes the redundant test_idle_cores() for