Re: [PATCH] sched/fair: Optimize dequeue_task_fair()(Internet mail)

2020-08-11 Thread 蒋彪
Hi, > On Aug 12, 2020, at 12:55 AM, Dietmar Eggemann > wrote: > > On 11/08/2020 10:43, Jiang Biao wrote: >> Similar optimization as what has been done in commit, >> 7d148be69e3a(sched/fair: Optimize enqueue_task_fair()) >> >> dequeue_task_fair jumps to dequeue_throttle label when cfs_rq_of(se)

Re: [PATCH] sched/fair: Optimize dequeue_task_fair()

2020-08-11 Thread Dietmar Eggemann
On 11/08/2020 10:43, Jiang Biao wrote: > Similar optimization as what has been done in commit, > 7d148be69e3a(sched/fair: Optimize enqueue_task_fair()) > > dequeue_task_fair jumps to dequeue_throttle label when cfs_rq_of(se) is > throttled which means that se can't be NULL. We can move the label a

[PATCH] sched/fair: Optimize dequeue_task_fair()

2020-08-11 Thread Jiang Biao
Similar optimization as what has been done in commit, 7d148be69e3a(sched/fair: Optimize enqueue_task_fair()) dequeue_task_fair jumps to dequeue_throttle label when cfs_rq_of(se) is throttled which means that se can't be NULL. We can move the label after the if (!se) statement and remove the if(!se

Re: [PATCH] sched/fair: Optimize dequeue_task_fair()

2020-06-15 Thread Peng Wang
On 6/15/20 11:09 PM, Vincent Guittot wrote: On Mon, 15 Jun 2020 at 16:20, Peng Wang wrote: While looking at enqueue_task_fair and dequeue_task_fair, it occurred to me that dequeue_task_fair can also be optimized as Vincent described in commit 7d148be69e3a ("sched/fair: Optimize enqueue_task_fa

Re: [PATCH] sched/fair: Optimize dequeue_task_fair()

2020-06-15 Thread Vincent Guittot
On Mon, 15 Jun 2020 at 16:20, Peng Wang wrote: > > While looking at enqueue_task_fair and dequeue_task_fair, it occurred > to me that dequeue_task_fair can also be optimized as Vincent described > in commit 7d148be69e3a ("sched/fair: Optimize enqueue_task_fair()"). good point > > dequeue_throttl

[PATCH] sched/fair: Optimize dequeue_task_fair()

2020-06-15 Thread Peng Wang
While looking at enqueue_task_fair and dequeue_task_fair, it occurred to me that dequeue_task_fair can also be optimized as Vincent described in commit 7d148be69e3a ("sched/fair: Optimize enqueue_task_fair()"). dequeue_throttle label can ensure se not to be NULL, and se is always NULL when reachin