Re: [PATCH] sched/fair: Fix dereference NULL sched domain during select_idle_sibling

2016-10-08 Thread Wanpeng Li
2016-10-09 1:06 GMT+08:00 Peter Zijlstra : > On Sat, Oct 08, 2016 at 06:24:38PM +0800, Wanpeng Li wrote: > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 543b2f2..03a6620 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -5472,19 +5472,29 @@ static inline in

Re: [PATCH] sched/fair: Fix dereference NULL sched domain during select_idle_sibling

2016-10-08 Thread Peter Zijlstra
On Sat, Oct 08, 2016 at 06:24:38PM +0800, Wanpeng Li wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 543b2f2..03a6620 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5472,19 +5472,29 @@ static inline int select_idle_smt(struct task_struct > *p, struct

[PATCH] sched/fair: Fix dereference NULL sched domain during select_idle_sibling

2016-10-08 Thread Wanpeng Li
From: Wanpeng Li Commit: 10e2f1acd01 ("sched/core: Rewrite and improve select_idle_siblings()") ... improved select_idle_sibling() but also triggered a regression: BUG: unable to handle kernel NULL pointer dereference at 0078 IP: [] select_idle_sibling+0x1c2/0x4f0 PGD 0 Oops: 00