Re: [PATCH] sched, numa: Use {cpu, pid} to create task groups for shared faults

2013-07-31 Thread Peter Zijlstra
On Wed, Jul 31, 2013 at 11:45:09AM -0400, Don Morris wrote: > > + > > +static void task_numa_free(struct task_struct *p) > > +{ > > + kfree(p->numa_faults); > > + if (p->numa_group) { > > + struct numa_group *grp = p->numa_group; > > See below. > > > + int i; > > + > > +

Re: [PATCH] sched, numa: Use {cpu, pid} to create task groups for shared faults

2013-07-31 Thread Don Morris
On 07/31/2013 11:07 AM, Peter Zijlstra wrote: > > New version that includes a final put for the numa_group struct and a > few other modifications. > > The new task_numa_free() completely blows though, far too expensive. > Good ideas needed. > > --- > Subject: sched, numa: Use {cpu, pid} to creat

Re: [PATCH] sched, numa: Use {cpu, pid} to create task groups for shared faults

2013-07-31 Thread Peter Zijlstra
On Wed, Jul 31, 2013 at 05:07:51PM +0200, Peter Zijlstra wrote: > @@ -1260,6 +1400,23 @@ void task_numa_fault(int last_cpupid, in > } > > /* > + * First accesses are treated as private, otherwise consider accesses > + * to be private if the accessing pid has not changed > +

Re: [PATCH] sched, numa: Use {cpu, pid} to create task groups for shared faults

2013-07-31 Thread Peter Zijlstra
New version that includes a final put for the numa_group struct and a few other modifications. The new task_numa_free() completely blows though, far too expensive. Good ideas needed. --- Subject: sched, numa: Use {cpu, pid} to create task groups for shared faults From: Peter Zijlstra Date: Tue

[PATCH] sched, numa: Use {cpu, pid} to create task groups for shared faults

2013-07-30 Thread Peter Zijlstra
Subject: sched, numa: Use {cpu, pid} to create task groups for shared faults From: Peter Zijlstra Date: Tue Jul 30 10:40:20 CEST 2013 A very simple/straight forward shared fault task grouping implementation. Concerns are that grouping on a single shared fault might be too aggressive -- this onl