Re: [PATCH] s390/pci: Remove unnecessary if condition

2016-07-31 Thread Julia Lawall
On Fri, 29 Jul 2016, Sebastian Ott wrote: > On Fri, 29 Jul 2016, Julia Lawall wrote: > > On Fri, 29 Jul 2016, Sebastian Ott wrote: > > > On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > > > > Remove unnecessary error handling because the only failure value that > > > > can be returned is NULL an

Re: [PATCH] s390/pci: Remove unnecessary if condition

2016-07-29 Thread Sebastian Ott
On Fri, 29 Jul 2016, Julia Lawall wrote: > On Fri, 29 Jul 2016, Sebastian Ott wrote: > > On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > > > Remove unnecessary error handling because the only failure value that > > > can be returned is NULL and so the test can never be true. > > > > > > The Coccin

Re: [PATCH] s390/pci: Remove unnecessary if condition

2016-07-29 Thread Julia Lawall
On Fri, 29 Jul 2016, Sebastian Ott wrote: > On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > > Remove unnecessary error handling because the only failure value that > > can be returned is NULL and so the test can never be true. > > > > The Coccinelle semantic patch used to make this change is as

Re: [PATCH] s390/pci: Remove unnecessary if condition

2016-07-29 Thread Sebastian Ott
On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > Remove unnecessary error handling because the only failure value that > can be returned is NULL and so the test can never be true. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e = debugfs

[PATCH] s390/pci: Remove unnecessary if condition

2016-07-29 Thread Amitoj Kaur Chawla
Remove unnecessary error handling because the only failure value that can be returned is NULL and so the test can never be true. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ e = debugfs_create_file(...); - if(IS_ERR(e)) { e = NULL; } Signed-off-by: