Re: [PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Bartosz Golaszewski
On Wed, Jan 6, 2021 at 7:52 AM Bartosz Golaszewski wrote: > > On Wed, Jan 6, 2021 at 7:47 AM kernel test robot wrote: > > > > Hi Bartosz, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on abelloni/rtc-next] > > [also build test WARNING on v5.11-rc2 next-

Re: [PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Bartosz Golaszewski
On Wed, Jan 6, 2021 at 7:47 AM kernel test robot wrote: > > Hi Bartosz, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on abelloni/rtc-next] > [also build test WARNING on v5.11-rc2 next-20210104] > [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread kernel test robot
Hi Bartosz, I love your patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documen

[PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the managed variant of i2c_new_dummy_device() to shrink code and remove the goto label. We can drop the remove callback now too. Signed-off-by: Bartosz Golaszewski --- drivers/rtc/rtc-s5m.c | 34 -- 1 file changed, 8 insertions(+),

Re: [PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Bartosz Golaszewski
On Tue, Jan 5, 2021 at 5:50 PM Krzysztof Kozlowski wrote: > > On Tue, Jan 05, 2021 at 02:44:24PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Use the managed variant of i2c_new_dummy_device() to shrink code and > > remove the goto label. > > > > Signed-off-by: Bartosz G

Re: [PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Krzysztof Kozlowski
On Tue, Jan 05, 2021 at 02:44:24PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the managed variant of i2c_new_dummy_device() to shrink code and > remove the goto label. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/rtc/rtc-s5m.c | 24

[PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the managed variant of i2c_new_dummy_device() to shrink code and remove the goto label. Signed-off-by: Bartosz Golaszewski --- drivers/rtc/rtc-s5m.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c