Re: [PATCH] rtc: mc13xxx: fix a double-unlock issue

2020-05-03 Thread Markus Elfring
> … To fix this problem, > we need to call mc13xxx_lock() again in this error path. How do you think about a wording variant like the following? Change description: … Thus add a call of the function “mc13xxx_lock” in an if branch for the completion of the exception handling. Would y

[PATCH] rtc: mc13xxx: fix a double-unlock issue

2020-05-02 Thread wu000273
From: Qiushi Wu In function mc13xxx_rtc_probe, the mc13xxx_unlock() is called before rtc_register_device(). But in the error path of rtc_register_device(), the mc13xxx_unlock() is called again, which causes a double-unlock problem. To fix this problem, we need to call mc13xxx_lock() again in this