Re: [PATCH] rtc: add devm_rtc_device_{register,unregister}()

2013-02-25 Thread Andrew Morton
On Mon, 25 Feb 2013 15:33:45 -0800 "'Tejun Heo'" wrote: > On Mon, Feb 25, 2013 at 02:29:57PM -0800, Andrew Morton wrote: > > > + * Managed rtc_device_register(). The rtc_device returned from this > > > function > > > + * are automatically freed on driver detach. See rtc_device_register() > > > +

Re: [PATCH] rtc: add devm_rtc_device_{register,unregister}()

2013-02-25 Thread 'Tejun Heo'
On Mon, Feb 25, 2013 at 02:29:57PM -0800, Andrew Morton wrote: > > + * Managed rtc_device_register(). The rtc_device returned from this > > function > > + * are automatically freed on driver detach. See rtc_device_register() > > + * for more information. > > + */ > > I think the name is inappropr

Re: [PATCH] rtc: add devm_rtc_device_{register,unregister}()

2013-02-25 Thread 'Tejun Heo'
On Mon, Feb 25, 2013 at 04:35:53PM +0900, Jingoo Han wrote: > +static void devm_rtc_device_release(struct device *dev, void *res) > +{ > + struct rtc_device *rtc = *(struct rtc_device **)res; > + > + rtc_device_unregister(rtc); > +} > + > +static int devm_rtc_device_match(struct device *dev

Re: [PATCH] rtc: add devm_rtc_device_{register,unregister}()

2013-02-25 Thread Andrew Morton
On Mon, 25 Feb 2013 16:35:53 +0900 Jingoo Han wrote: > These functios allows the driver core to automatically clean up > any allocation made by rtc drivers. Thus, it simplifies the error > paths. > > ... > > @@ -259,6 +259,78 @@ void rtc_device_unregister(struct rtc_device *rtc) > } > EXPORT_S

[PATCH] rtc: add devm_rtc_device_{register,unregister}()

2013-02-24 Thread Jingoo Han
These functios allows the driver core to automatically clean up any allocation made by rtc drivers. Thus, it simplifies the error paths. Signed-off-by: Jingoo Han --- drivers/rtc/class.c | 72 +++ include/linux/rtc.h |6 2 files changed,