Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature

2015-04-10 Thread Alexandre Belloni
On 10/04/2015 at 13:37:30 -0700, Andrew Morton wrote : > Is there any way in which we can get all systems working properly? If > there's no way of auto-detecting an external oscillator then perhaps a > module parameter is needed. If so, it would be better if the driver > were to default to intern

Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature

2015-04-10 Thread Andrew Morton
On Fri, 10 Apr 2015 13:56:54 +0530 Keerthy wrote: > >>> How do we know that all systems have this external clock and that it > >>> works OK? > >>> > >> > >> AM335 and AM43X have the external clock feature which we choose using > >> RTC_OSC_REG. I verified it works OK by seeing the RTC seconds tic

Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature

2015-04-07 Thread Igor Grinberg
Hi, On 04/07/15 06:29, Keerthy wrote: > Hi Andrew, > > Apologies for replying late. > > On Wednesday 25 March 2015 04:29 AM, Andrew Morton wrote: >> On Tue, 3 Mar 2015 15:12:02 +0530 Keerthy wrote: >> >>> Add external 32k clock feature. The internal clock will be gated during >>> suspend. >>>

Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature

2015-04-06 Thread Keerthy
Hi Andrew, Apologies for replying late. On Wednesday 25 March 2015 04:29 AM, Andrew Morton wrote: On Tue, 3 Mar 2015 15:12:02 +0530 Keerthy wrote: Add external 32k clock feature. The internal clock will be gated during suspend. Hence make use of the external 32k clock so that rtc is function

Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature

2015-03-24 Thread Andrew Morton
On Tue, 3 Mar 2015 15:12:02 +0530 Keerthy wrote: > Add external 32k clock feature. The internal clock will be gated during > suspend. > Hence make use of the external 32k clock so that rtc is functional accross > suspend/resume. > > ... > > @@ -446,6 +449,7 @@ static const struct omap_rtc_devic

Re: [PATCH] rtc: OMAP: Add external 32k clock feature

2015-03-16 Thread Keerthy
On Tuesday 03 March 2015 03:12 PM, Keerthy wrote: Add external 32k clock feature. The internal clock will be gated during suspend. Hence make use of the external 32k clock so that rtc is functional accross suspend/resume. A gentle ping on this. Signed-off-by: Keerthy --- Tested on DRA7-E

[PATCH] rtc: OMAP: Add external 32k clock feature

2015-03-03 Thread Keerthy
Add external 32k clock feature. The internal clock will be gated during suspend. Hence make use of the external 32k clock so that rtc is functional accross suspend/resume. Signed-off-by: Keerthy --- Tested on DRA7-EVM. drivers/rtc/rtc-omap.c | 15 ++- 1 file changed, 14 insertions(