Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-29 Thread Palmer Dabbelt
On Thu, 16 May 2019 00:42:01 PDT (-0700), sch...@suse.de wrote: On Mai 07 2019, Palmer Dabbelt wrote: LMK if you, or anyone else, has a preference. I'm assuming this will go in through my tree, so I've picked up my version for now :) You did? It ended up landing in Linus' tree as 8fef9900

Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-16 Thread Andreas Schwab
On Mai 07 2019, Palmer Dabbelt wrote: > LMK if you, or anyone else, has a preference. I'm assuming this will go in > through my tree, so I've picked up my version for now :) You did? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4

Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-07 Thread Palmer Dabbelt
On Tue, 07 May 2019 00:36:46 PDT (-0700), sch...@suse.de wrote: When a user mode process accesses an address in the vmalloc area do_page_fault tries to unlock the mmap semaphore when it isn't locked. Signed-off-by: Andreas Schwab --- arch/riscv/mm/fault.c | 3 ++- 1 file changed, 2 insertions(

Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-07 Thread Andreas Schwab
On Mai 07 2019, Nikolay Borisov wrote: > On 7.05.19 г. 17:12 ч., Andreas Schwab wrote: >> On Mai 07 2019, Nikolay Borisov wrote: >> >>> At the very least the code under >>> no_context label could go into it's own function since it just kills the >>> process and never returns? >> >> This is not

Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-07 Thread Nikolay Borisov
On 7.05.19 г. 17:12 ч., Andreas Schwab wrote: > On Mai 07 2019, Nikolay Borisov wrote: > >> At the very least the code under >> no_context label could go into it's own function since it just kills the >> process and never returns? > > This is not true. Be more specific, according to do_task_

Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-07 Thread Andreas Schwab
On Mai 07 2019, Nikolay Borisov wrote: > At the very least the code under > no_context label could go into it's own function since it just kills the > process and never returns? This is not true. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F

Re: [PATCH] riscv: fix locking violation in page fault handler

2019-05-07 Thread Nikolay Borisov
On 7.05.19 г. 10:36 ч., Andreas Schwab wrote: > When a user mode process accesses an address in the vmalloc area > do_page_fault tries to unlock the mmap semaphore when it isn't locked. > > Signed-off-by: Andreas Schwab > --- > arch/riscv/mm/fault.c | 3 ++- > 1 file changed, 2 insertions(+),

[PATCH] riscv: fix locking violation in page fault handler

2019-05-07 Thread Andreas Schwab
When a user mode process accesses an address in the vmalloc area do_page_fault tries to unlock the mmap semaphore when it isn't locked. Signed-off-by: Andreas Schwab --- arch/riscv/mm/fault.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/mm/fault.c b/arch/riscv