Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-24 Thread Alexandre Ghiti
On 20/06/2024 19:03, Alexandre Ghiti wrote: On 19/06/2024 05:40, Andy Chiu wrote: On Tue, Jun 18, 2024 at 9:40 PM Alexandre Ghiti wrote: Hi Andy, On Tue, Jun 18, 2024 at 2:48 PM Andy Chiu wrote: On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: Hi Conor, On 17/06/2024 15:23, Alex

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-20 Thread Alexandre Ghiti
On 19/06/2024 05:40, Andy Chiu wrote: On Tue, Jun 18, 2024 at 9:40 PM Alexandre Ghiti wrote: Hi Andy, On Tue, Jun 18, 2024 at 2:48 PM Andy Chiu wrote: On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: Hi Conor, On 17/06/2024 15:23, Alexandre Ghiti wrote: Hi Conor, Sorry for the d

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Andy Chiu
On Tue, Jun 18, 2024 at 9:40 PM Alexandre Ghiti wrote: > > Hi Andy, > > On Tue, Jun 18, 2024 at 2:48 PM Andy Chiu wrote: > > > > On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: > > > > > > Hi Conor, > > > > > > On 17/06/2024 15:23, Alexandre Ghiti wrote: > > > > Hi Conor, > > > > > > > >

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Alexandre Ghiti
Hi Andy, On Tue, Jun 18, 2024 at 2:48 PM Andy Chiu wrote: > > On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: > > > > Hi Conor, > > > > On 17/06/2024 15:23, Alexandre Ghiti wrote: > > > Hi Conor, > > > > > > Sorry for the delay here. > > > > > > On 13/06/2024 09:48, Conor Dooley wrote: >

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Andy Chiu
On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: > > Hi Conor, > > On 17/06/2024 15:23, Alexandre Ghiti wrote: > > Hi Conor, > > > > Sorry for the delay here. > > > > On 13/06/2024 09:48, Conor Dooley wrote: > >> On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: > >>> Commit c

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Alexandre Ghiti
Hi Conor, On 17/06/2024 15:23, Alexandre Ghiti wrote: Hi Conor, Sorry for the delay here. On 13/06/2024 09:48, Conor Dooley wrote: On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: Commit c97bf629963e ("riscv: Fix text patching when IPI are used") converted ftrace_make_nop() t

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-17 Thread Alexandre Ghiti
Hi Conor, Sorry for the delay here. On 13/06/2024 09:48, Conor Dooley wrote: On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: Commit c97bf629963e ("riscv: Fix text patching when IPI are used") converted ftrace_make_nop() to use patch_insn_write() which does not emit any icache

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-13 Thread Conor Dooley
On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: > Commit c97bf629963e ("riscv: Fix text patching when IPI are used") > converted ftrace_make_nop() to use patch_insn_write() which does not > emit any icache flush relying entirely on __ftrace_modify_code() to do > that. > > But we m

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-05-23 Thread patchwork-bot+linux-riscv
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Thu, 23 May 2024 13:51:34 +0200 you wrote: > Commit c97bf629963e ("riscv: Fix text patching when IPI are used") > converted ftrace_make_nop() to use patch_insn_write() which does not > emit any icache flush relying

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-05-23 Thread Conor Dooley
On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: > Commit c97bf629963e ("riscv: Fix text patching when IPI are used") > converted ftrace_make_nop() to use patch_insn_write() which does not > emit any icache flush relying entirely on __ftrace_modify_code() to do > that. > > But we m

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-05-23 Thread Björn Töpel
Alexandre Ghiti writes: > Commit c97bf629963e ("riscv: Fix text patching when IPI are used") > converted ftrace_make_nop() to use patch_insn_write() which does not > emit any icache flush relying entirely on __ftrace_modify_code() to do > that. > > But we missed that ftrace_make_nop() was called

[PATCH] riscv: Fix early ftrace nop patching

2024-05-23 Thread Alexandre Ghiti
Commit c97bf629963e ("riscv: Fix text patching when IPI are used") converted ftrace_make_nop() to use patch_insn_write() which does not emit any icache flush relying entirely on __ftrace_modify_code() to do that. But we missed that ftrace_make_nop() was called very early directly when converting m