Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
On 20-08-2024 20:29, Beleswar Prasad Padhi wrote: On 20-08-2024 19:50, Jan Kiszka wrote: On 20.08.24 11:48, Beleswar Prasad Padhi wrote: On 20-08-2024 15:09, Jan Kiszka wrote: On 20.08.24 11:30, Beleswar Prasad Padhi wrote: Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
On 20-08-2024 19:50, Jan Kiszka wrote: On 20.08.24 11:48, Beleswar Prasad Padhi wrote: On 20-08-2024 15:09, Jan Kiszka wrote: On 20.08.24 11:30, Beleswar Prasad Padhi wrote: Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is sh

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Jan Kiszka
On 20.08.24 11:48, Beleswar Prasad Padhi wrote: > > On 20-08-2024 15:09, Jan Kiszka wrote: >> On 20.08.24 11:30, Beleswar Prasad Padhi wrote: >>> Hi Jan, >>> >>> On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and rem

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
On 20-08-2024 15:09, Jan Kiszka wrote: On 20.08.24 11:30, Beleswar Prasad Padhi wrote: Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and removed first. When core 0 should then be stopped before its removal, it will

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Jan Kiszka
On 20.08.24 11:30, Beleswar Prasad Padhi wrote: > Hi Jan, > > On 19-08-2024 22:17, Jan Kiszka wrote: >> From: Jan Kiszka >> >> When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and removed >> first. When core 0 should then be stopped before its removal, it will >> find core1->rproc as NULL

Re: [PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-20 Thread Beleswar Prasad Padhi
Hi Jan, On 19-08-2024 22:17, Jan Kiszka wrote: From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and removed first. When core 0 should then be stopped before its removal, it will find core1->rproc as NULL already and crashes. Happens on rmmod e.g. Did you check this

[PATCH] remoteproc: k3-r5: Fix driver shutdown

2024-08-19 Thread Jan Kiszka
From: Jan Kiszka When k3_r5_cluster_rproc_exit is run, core 1 is shutdown and removed first. When core 0 should then be stopped before its removal, it will find core1->rproc as NULL already and crashes. Happens on rmmod e.g. Fixes: 3c8a9066d584 ("remoteproc: k3-r5: Do not allow core1 to power up